Hey, > A while back i suggested we re-work the /proc/net/batman/vis format. > Attached are two patches to achieve this. One patch is for the kernel > model sources and the second extends batctl so that it can read from > the /proc file and output dot or json format as before. The patch > includes documentation for the new new batctl command in the man page.
I reviewed the patches & fixed some issues: * vis raw data (kernel): I upgraded the patch to make it apply on the latest trunk and added a descriptive commit message * vis raw data (batctl): I did not change anything but I'd like to suggest we adapt the coding style to match the rest of batctl (maybe using Lindent?). Also, all other batctl modules follow the same behaviour regarding the "-h" option. To be consistent we may want to adapt that as well. * vis_format remove: This patch removed the vis_format initializations but not the corresponding free calls. I fixed that. * I added an additional patch (splitting /proc vis file into vis_server and vis_data) to follow the roadmap we layed out in Brussels. * Last but not least: the mandatory batctl vis data path change Please give it some more testing, Marek
