Hi,

> This fixes the bug discovered by Marek which did not allow turning on
> the vis-server before an interface has been added. This is now being
> done in a similar way as for (de)activating the aggregation mode with an
> atomic variable.

great that you work on this!  :)

I'm no expert on the vis code but here my 2 cents:
* You hard-coded integer values instead of using the existing defines. Any 
reason for that ?
* my_vis_info->packet.vis_type never gets updated ?
* This patch removes functionality from the /proc parsing function although 
this is not related to the patch-topic. 
* checkpatch reports 8 errors & 8 warnings

Regards,
Marek

Reply via email to