Hi, On Tue, Jul 20, 2010 at 1:23 PM, Marek Lindner <[email protected]> wrote: > On Tuesday, July 20, 2010 18:59:28 David Miller wrote: >> Whoever you leave it to, this needs to be fixed up before this >> code can be integrated. So if those people are not active or >> don't have time, you very much should consider the reality that >> you might have to do these fixups yourself. > > No worries - we are quite alive and follow the discussion closely. The raised > issues will be addressed pretty soon. > > @Sven: I think you do a great job integrating all those patches and trees. > Your helping hand would be really missed. :)
Minor comments... 1. Is it ok to have a README in drivers directory? why not moving it to Documentation/networking? 2. Compilation error, one extra arguments passed - stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp); + stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp); LD kernel/built-in.o net/batman-adv/hard-interface.c: In function 'batman_skb_recv': net/batman-adv/hard-interface.c:482: error: too many arguments to function 'dev_get_stats' make[2]: *** [net/batman-adv/hard-interface.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [net/batman-adv] Error 2 make: *** [net] Error 2 Best Regards Abraham
