Re: [B.A.T.M.A.N.] batman-adv: unicast fragmentation enhancements

[Sven Eckelmann]

Andy Whitcroft wrote:
> On Fri, Sep 17, 2010 at 12:27:13AM +0200, Sven Eckelmann wrote:
> > Andreas Langer wrote:
> > > Sven, any idea why checkpatch (0.31)b do this ?
> > > 
> > > ERROR: space prohibited after that '-' (ctx:WxW)
> > > #10: FILE: batman-adv/routing.c:1146:
> > > +     uni_diff = sizeof(struct unicast_frag_packet) - hdr_len;
> > 
> > Because... what the heck? Usually it says that you should use consistent
> > spaces around '-'. So better use spaces in patch 1 and 6 and don't remove
> > the space before hdr_len as you did now.
> 
> Because it is wrong.  I believe that I've fixed that one up in my
> development tree.  Could you confirm it is correctly left alone with the
> version below:
> 
>  
> http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl
> -testing

Yes, the testing version doesn't show that behavior.

thanks,
        Sven

signature.asc
Description: This is a digitally signed message part.