On Saturday, March 05, 2016 16:09:16 Sven Eckelmann wrote: > The batadv_hardif_list list is checked in many situations and the items > in this list are given to specialized functions to modify the routing > behavior. At the moment each of these called functions has to check > itself whether the received batadv_hard_iface has a refcount > 0 before > it can increase the reference counter and use it in other objects. > > This can easily lead to problems because it is not easily visible where > all callers of a function got the batadv_hard_iface object from and > whether they already hold a valid reference. > > Checking the reference counter directly before calling a subfunction > with a pointer from the batadv_hardif_list avoids this problem. > > Signed-off-by: Sven Eckelmann <[email protected]> > --- > net/batman-adv/bat_iv_ogm.c | 11 +++++++++++ > net/batman-adv/bat_v_ogm.c | 14 +++++++++++++- > net/batman-adv/originator.c | 5 +++++ > net/batman-adv/send.c | 6 ++++++ > 4 files changed, 35 insertions(+), 1 deletion(-)
Applied in revision bd2dcf5. Thanks, Marek
signature.asc
Description: This is a digitally signed message part.
