On Thursday 30 June 2016 20:11:33 Sven Eckelmann wrote:
> The pointer batadv_bla_claim::backbone_gw can be changed at any time.
> Therefore, access to it must be protected to ensure that two function
> accessing the same backbone_gw are actually accessing the same. This is
> especially important when the crc_lock is used or when the backbone_gw of a
> claim is exchanged.
>
> Not doing so leads to invalid memory access and/or reference leaks.
>
> Fixes: a9ce0dc43e2c ("batman-adv: add basic bridge loop avoidance code")
> Fixes: b307e72d119f ("batman-adv: lock crc access in bridge loop avoidance")
> Signed-off-by: Sven Eckelmann <s...@narfation.org>
Technically, you can already add my "Acked-by". However I'd like to suggest
one style change: Could you please rename batadv_bla_claim_backbone_gw into
batadv_bla_claim_get_backbone_gw? I think this would make it clearer what the
function does and also shows get/put pairs clearly in the code.
Thanks!
Simon
signature.asc
Description: This is a digitally signed message part.
