On Monday, June 20, 2016 19:54:49 Sven Eckelmann wrote:
> The dev_xmit_complete function is only necessary to check the return value
> for *_hard_xmit functions. But batman-adv only uses dev_queue_xmit to send
> data via the interface queue.
> 
> From the kerneldoc of __dev_queue_xmit:
> 
>     Regardless of the return value, the skb is consumed, so it is currently
>     difficult to retry a send to this method.  (You can bump the ref count
>     before sending to hold a reference for retry if you are careful.)
> 
> Fixes: e3b8acbff9c8 ("batman-adv: return netdev status in the TX path")
> Signed-off-by: Sven Eckelmann <[email protected]>
> ---
> v2:
>  - added this patch
> 
>  net/batman-adv/routing.c | 10 ++++------
>  net/batman-adv/send.c    |  2 +-
>  net/batman-adv/tvlv.c    |  2 +-
>  3 files changed, 6 insertions(+), 8 deletions(-)

Applied in revision 1718050.

Thanks,
Marek

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to