On Dienstag, 5. Juli 2016 20:01:37 CEST Linus Lüssing wrote: > /** > + * batadv_dat_check_dhcp_ipudp - check skb for IP+UDP headers valid for > DHCP + * @skb: the packet to check > + * @proto: ethernet protocol hint (behind a potential vlan) > + * > + * Checks whether the given skb has an IP and UDP header valid for a DHCP > + * message from a DHCP server. > + * > + * Return: True if valid, false otherwise. > + */ > +static bool batadv_dat_check_dhcp_ipudp(struct sk_buff *skb) > +{
Looks like this function doesn't have the parameter proto which you've described in the kerneldoc. It sounds like the patch didn't help. So I will postpone my review. Kind regards, Sven
signature.asc
Description: This is a digitally signed message part.