On Monday, 13 August 2018 03:04:42 HKT Sven Eckelmann wrote:
> The function batadv_nc_get_nc_node is responsible for adding new nc_nodes
> to the in_coding_list and out_coding_list. It first checks whether the
> entry already is in the list or not. If it is, then the creation of a new
> entry is aborted.
> 
> But the lock for the list is only held when the list is really modified.
> This could lead to duplicated entries because another context could create
> an entry with the same key between the check and the list manipulation.
> 
> The check and the manipulation of the list must therefore be in the same
> locked code section.
> 
> Fixes: 3ed7ada3f0bb ("batman-adv: network coding - detect coding nodes and
> remove these after timeout") Signed-off-by: Sven Eckelmann
> <s...@narfation.org>

Acked-by: Marek Lindner <mareklind...@neomailbox.ch>

Cheers,
Marek

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to