On Saturday, 16 November 2024 22:32:09 CET Remi Pommarel wrote:
> --- a/net/batman-adv/translation-table.c
> +++ b/net/batman-adv/translation-table.c
> @@ -500,14 +500,17 @@ static void batadv_tt_local_event(struct batadv_priv
> *bat_priv,
> /* this is a second add in the same originator interval. It
> * means that flags have been changed: update them!
> */
> - if (!del_op_requested && !del_op_entry)
> + if (del_op_requested == del_op_entry) {
> entry->change.flags = flags;
> + goto discard;
> + }
The comment is no longer in sync with the actual code. It is now also about
DEL's and and only about ADDs.
And I am not sure about the flags update on DELs - maybe Antonio can enlighten
us here.
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
