Re: [PATCH batadv] batman-adv: gw: don't deselect gateway with active hardif

[Sven Eckelmann]

On Wednesday, 10 June 2026 19:50:12 CEST Nora Schiffer wrote:
[...]
> >     /* nobody uses this interface anymore */
> > -   if (batadv_hardif_cnt(hard_iface->mesh_iface) <= 1)
> > +   if (batadv_hardif_cnt(hard_iface->mesh_iface) == 0)
> >             batadv_gw_check_client_stop(bat_priv);
> 
> The change looks correct, but this is the only remaining user of 
> batadv_hardif_cnt(), and it's only checking if there aren't any hardifs, so 
> this could avoid counting altogether and just use
> 
>       if (list_empty(&hard_iface->mesh_iface->adj_list.lower))
> 
> and drop batadv_hardif_cnt().

Good point. Will submit a new version.

> We are holding RTNL here, right?

Yes, all callers are holding RTNL.

Regards,
        Sven

signature.asc
Description: This is a digitally signed message part.