> This hacks leads to incorrect SPROM parsing for me and reading for
> example MAC as: 00:00:00:54:00:00. Michael G. who introduced this
> confirmed it is not needed anymore.
> 
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---
> Michael: I guess I could add your Tested-by. Is that right?

That ist right. I suppose the correct entry would be
Tested-by: Michael Gerdau <[email protected]>

> John: it's 2.6.38 ofc. It should apply cleanly no matter if you applied
> my previous patch for guessing unknown SPROM revision. There is not
> dependence between that 2 patches.
> ---
>  drivers/ssb/pci.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index b5343ac..f529663 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -580,10 +580,6 @@ static int sprom_extract(struct ssb_bus *bus, struct
> ssb_sprom *out, * Always extract r1. */
>               out->revision = 1;
>               ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n",
> out->revision); -     } else if (bus->chip_id == 0x4321) {
> -             /* the BCM4328 has a chipid == 0x4321 and a rev 4 SPROM */
> -             out->revision = 4;
> -             ssb_dprintk(KERN_DEBUG PFX "SPROM treated as revision %d\n",
> out->revision); }
> 
>       switch (out->revision) {


-- 
 Michael Gerdau       email: [email protected]
 GPG-keys available on request or at public keyserver

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev

Reply via email to