On Wed, 23 Apr 2014 12:53:02 +0000
David Binderman <[email protected]> wrote:

> [fwcutter.c:497]: (error) Dangerous usage of 'shortname' (strncpy doesn't 
> always null-terminate it).
> 
> Source code is
> 
>     if (strlen(file->name)> 20) {
>         strncpy(shortname, file->name, 18);
>         snprintf(filename, sizeof(filename), "%s..", shortname);
>     } else
>         strcpy (filename, file->name);

Please upgrade to a non-ancient version of fwcutter.
http://bues.ch/b43/fwcutter/

Current versions do this:

>       if (strlen(file->name) > 20) {
>               strncpy(shortname, file->name, 20);
>               shortname[20] = '\0';
>               snprintf(filename, sizeof(filename), "%s..", shortname);
>       } else
>               strcpy (filename, file->name);



-- 
Michael.

----
Please use PGP/GPG encryption.
Key-ID: F532BE1D908D8B0E
--------

Attachment: signature.asc
Description: PGP signature

_______________________________________________
b43-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/b43-dev

Reply via email to