Michael, I don't have hardware for this driver on me, so I didn't test it. However this seems to be correct from my reading of the code around this function and other locking related to this driver. Cheers Nick
On 2014-11-28 06:21 PM, Michael Büsch wrote: > On Fri, 28 Nov 2014 23:40:46 +0100 > Rafał Miłecki <[email protected]> wrote: > >>> @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw >>> *hw, >>> { >>> struct b43_wl *wl = hw_to_b43_wl(hw); >>> >>> - /* FIXME: add locking */ >>> + mutex_lock(&wl->mutex); >>> b43_update_templates(wl); >>> + mutex_unlock(&wl->mutex); >>> >>> return 0; >>> } >> >> Does anyone remember why this simple solution wasn't implemented >> earlier? Michael? > > I think the callback used to be (is?) in atomic context. > >> Nicholas: did you test it anyhow? > _______________________________________________ b43-dev mailing list [email protected] http://lists.infradead.org/mailman/listinfo/b43-dev
