[BackupPC-users] nbsp PATCH [was: BackupPC 2.1.2 released]

[David Relson]

Hello Craig,

Thanks for a great program!  As a minor contribution, I've noticed an
html display flaw and am enclosing patches that fix the flaw in the 2
places I've seen it.  There might be other places, notably in the other
Lang/*.pm files.

I'd sent these patches about 3 weeks ago, but guess they were
overlooked.  I hope they help.

Regards,

David

******** the problem ********

The "Status" screen is sometimes missing the separator bars in
the tables it displays.  This is a browser quirk (flaw?) that happens
when there are consecutive empty <td> fields, for example in:

    <tr><td class="border">  admin  </td>
        <td class="border" align="center">  </td>
        <td class="border" align="center">  </td>
        <td class="border"> 8/26 01:00 </td>
        <td class="border"> BackupPC_nightly -m 0 127 </td>
        <td class="border" align="center"> 27587 </td>
        <td class="border" align="center">  </td>
    </tr>

The fix is to add an "&nbsp;" character to the output, i.e.

    <tr><td class="border">  admin  </td>
        <td class="border" align="center"> &nbsp; </td>
        <td class="border" align="center"> &nbsp; </td>
        <td class="border"> 8/26 01:00 </td>
        <td class="border"> BackupPC_nightly -m 0 127 </td>
        <td class="border" align="center"> 27587 </td>
        <td class="border" align="center"> &nbsp; </td>
    </tr>



--- CGI/GeneralInfo.pm.orig     2005-05-21 14:06:17.000000000 -0400
+++ CGI/GeneralInfo.pm  2005-08-26 04:04:33.000000000 -0400
@@ -56,13 +56,13 @@
         (my $xferPid = $Jobs{$host}{xferPid}) =~ s/,/, /g;
         $jobStr .= <<EOF;
 <tr><td class="border"> ${HostLink($host)} </td>
-    <td align="center" class="border"> $Jobs{$host}{type} </td>
+    <td align="center" class="border"> $Jobs{$host}{type}&nbsp;</td>
     <td align="center" class="border"> ${UserLink(defined($Hosts->{$host})
-                                       ? $Hosts->{$host}{user} : "")} </td>
-    <td class="border"> $startTime </td>
-    <td class="border"> $cmd </td>
-    <td align="center" class="border"> $Jobs{$host}{pid} </td>
-    <td align="center" class="border"> $xferPid </td>
+                                       ? $Hosts->{$host}{user} : 
"")}&nbsp;</td>
+    <td class="border"> $startTime&nbsp;</td>
+    <td class="border"> $cmd&nbsp;</td>
+    <td align="center" class="border"> $Jobs{$host}{pid}&nbsp;</td>
+    <td align="center" class="border"> $xferPid&nbsp;</td>
 EOF
         $jobStr .= "</tr>\n";
     }

--- Lang/en.pm.orig     2005-05-21 14:06:16.000000000 -0400
+++ Lang/en.pm  2005-08-26 04:23:22.000000000 -0400
@@ -667,7 +667,7 @@
 Empty files and SMB errors aren\'t counted in the reuse and new counts.
 </p>
 <table class="tableStnd" border cellspacing="1" cellpadding="3" width="80%">
-<tr class="tableheader"><td colspan="2" bgcolor="#ffffff"></td>
+<tr class="tableheader"><td colspan="2" bgcolor="#ffffff">&nbsp;</td>
     <td align="center" colspan="3"> Totals </td>
     <td align="center" colspan="2"> Existing Files </td>
     <td align="center" colspan="2"> New Files </td>
@@ -693,7 +693,7 @@
 compressed files.
 </p>
 <table class="tableStnd" border cellspacing="1" cellpadding="3" width="80%">
-<tr class="tableheader"><td colspan="3" bgcolor="#ffffff"></td>
+<tr class="tableheader"><td colspan="3" bgcolor="#ffffff">&nbsp;</td>
     <td align="center" colspan="3"> Existing Files </td>
     <td align="center" colspan="3"> New Files </td>
 </tr>