Hi,
Thomas G?nther wrote on 03.07.2007 at 13:31:43 [Re: [BackupPC-users] problems
during/after backup]:
> Holger Parplies schrieb:
> >If you don't want to upgrade, you can patch 2.1.2:
> >
> >--- lib/BackupPC/Xfer/Tar.pm Sun Jan 8 23:25:54 2006
> >+++ /tmp/Tar.pm Tue Jul 3 11:10:04 2007
> >@@ -198,7 +198,12 @@
> > my $mesg;
> > if ( sysread($t->{pipeTar}, $mesg, 8192) <= 0 ) {
> > vec($$FDreadRef, fileno($t->{pipeTar}), 1) = 0;
> >- if ( !close($t->{pipeTar}) ) {
> >+ if ( !close($t->{pipeTar}) && $! != 256 ) {
> >+ #
> >+ # Tar 1.16 uses exit status 1 (256) when some files
> >+ # changed during archive creation. We allow this
> >+ # as a benign error and consider the archive ok
> >+ #
> > $t->{tarOut} .= "Tar exited with error $? ($!) status\n";
> > $t->{xferOK} = 0 if ( !$t->{tarBadExitOk} );
> > }
>
> [that didn't work]
yes, sorry, my fault. There's a typo in my patch. You applied the patch
correctly and to the correct file (/path/to/lib/BackupPC/Xfer/Tar.pm).
The patch should have tested $? and not $! ... in context:
if ( !close($t->{pipeTar}) && $? != 256 ) {
I would prefer to test these things before sending them to the list, but
it's not really trivial in this case, is it? :). I had copied the comment
from BackupPC 3.0.0 after first applying my patch from memory and then
"checking" in 3.0.0 if it was correct. Seems I didn't look close enough. I
hope I did this time.
Regards,
Holger
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/backuppc-users
http://backuppc.sourceforge.net/
