Les Mikesell wrote:
> Joe Krahn wrote:
>> It seems to be a known problem that moving the backup location by
>> setting $Conf{TopDir} does not work, because it is used to define the
>> location of config.pl when $useFHS is off. But, changing $TopDir breaks
>> BackupPC_link even when $useFHS is on. It is confusing that the config
>> value is used some places, but the default value is used in others.
>
> It's a known problem for versions pre-packaged for Linux distributions,
> and it's an artifact of packaging.
>
>> If certain values have to be hard-coded, then you shouldn't also allow
>> those as configuration options.
>
> They aren't really hard coded - they are substituted during
> installation, but the packaged versions don't repeat this step.
>
>> There is also no reason to force the
>> backup pool to be in the same location as the config file, because it
>> will be quite common to have a separate filesystem for backup data, so
>> the backup locations should definitely not be one of the hard-coded
>> items.
>
> That's a generic problem of Linux distributions trying to standardize
> file and directory locations. But the easy fix is to copy the existing
> content to your new partition, then either mount it in the old location
> or replace the old location with a symlink.
>
I disagree. You might consider it an install-time setting, but then it
should not be a modifiable value in config.pl. Even so, why make the
backup path a one-time install setting?
I changed Lib.pm (see below), and it now seems to honor $TopDir changes.
Is there any reason not to make this change? Even if this was done on
purpose to avoid losing all of the hardlink data management, all of the
pc/ data paths should be handled the same way as the pool paths.
Joe Krahn
*** BackupPC.orig/usr/share/BackupPC/lib/BackupPC/Lib.pm
2008-02-11 18:26:14.000000000 -0500
--- /usr/share/BackupPC/lib/BackupPC/Lib.pm 2008-02-13
10:49:21.000000000 -0500
***************
*** 152,159 ****
# Clean up %ENV and setup other variables.
#
delete @ENV{qw(IFS CDPATH ENV BASH_ENV)};
- $bpc->{PoolDir} = "$bpc->{TopDir}/pool";
- $bpc->{CPoolDir} = "$bpc->{TopDir}/cpool";
if ( defined(my $error = $bpc->ConfigRead()) ) {
print(STDERR $error, "\n");
return;
--- 152,157 ----
***************
*** 166,171 ****
--- 164,171 ----
next if ( $bpc->{Conf}{$dir} eq "" );
$paths->{$dir} = $bpc->{$dir} = $bpc->{Conf}{$dir};
}
+ $bpc->{PoolDir} = "$bpc->{TopDir}/pool";
+ $bpc->{CPoolDir} = "$bpc->{TopDir}/cpool";
$bpc->{storage}->setPaths($paths);
#
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
BackupPC-users mailing list
[email protected]
List: https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki: http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
