Second patch seems better. Ideally, though it would be nice if the function would be allow you to alternatively specify just a path without a share name similar to how directories are stored in the 'pc' directory or how they are mounted when using backuppcfs. i.e., if your share is named 'root' (for '/') then you could just do: BackupPC_backupDelete -h HOSTNAME -n 742 -s /root/etc/something If your only share is actually '/' then you could do: BackupPC_backupDelete -h HOSTNAME -n 742 /etc/something
It may also be nice to have the option to confirm before deleting... (like with 'rm -i') G.W. Haywood wrote at about 17:42:49 +0100 on Friday, October 10, 2025: > Hi there, > > The oldish Github issue > > https://github.com/backuppc/backuppc/issues/519 > > describes the unfortunate situation in the subject. > > The trigger was a syntax error when using the BackupPC_backupDelete > script from the command line: > > # Do not do this! At least not until there's a fix for #519. > $ BackupPC_backupDelete -h HOSTNAME -n 742 -s /etc/something > > In this case the name of the share is missing from the command. > > BackupPC_backupDelete issues seem to have caused little traffic here > on the List. I wondered if anyone has come across anything like this? > The most recent mention of anything similar that I found in the List > archives was from me, back in September 2018. So no, I don't use the > script from the command line very often. > > I've put a couple of patches in the comments for #519. The first is a > simple-minded thing. However I'd prefer something more robust, which > I hope the second patch would prove to be. But before I'd be happy to > release it, I'd like it to have more eyes on it and more exercise. > > If anyone would like to help test it I'd be grateful to hear either on > the List, over on the Github issue comments, or privately. There will > be enough information in #519 to patch the script, but I'd be happy to > mail the updated version or upload it someplace for download. I'm not > keen on branching/forking on Github but it's an option. > > My patch should have no effect on BackupPC's use of the script. I'm > pretty sure that this issue can only affect usage of BackupPC_delete > at the command-line, but other eyes on the code would be most welcome. > > -- > > 73, > Ged. > > > _______________________________________________ > BackupPC-users mailing list > [email protected] > List: https://lists.sourceforge.net/lists/listinfo/backuppc-users > Wiki: https://github.com/backuppc/backuppc/wiki > Project: https://backuppc.github.io/backuppc/ _______________________________________________ BackupPC-users mailing list [email protected] List: https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki: https://github.com/backuppc/backuppc/wiki Project: https://backuppc.github.io/backuppc/
