Hello Ged, I just provided the patch in https://github.com/backuppc/backuppc/issues/565
Br Matthias Am Donnerstag, dem 11.06.2026 um 17:12 +0200 schrieb [email protected]: > Hello Ged, > > "required" - I'm a german. I imagine my english could be improved🤣️ > > I'll develop and test the patch with $Conf{patch-defined-command} without > impementation in GUI and > send it here in the mailing list. > > Have a great day > Matthias > > > Am Donnerstag, dem 11.06.2026 um 15:20 +0100 schrieb G.W. Haywood: > > Hi there, > > > > On Wed, 10 Jun 2026, Matthias@gmx... wrote: > > > > > In BackupPC V4, if a new backup is started, we begin with > > > BackupPC_backupDuplicate of the last > > > recent backup number into the new backup number and DumpPreUserCmd will > > > be called afterwards. > > > This > > > can have a duration from some seconds till some hours. If the client go > > > to sleep during this > > > time, > > > the backup will fail. > > > I developed a patch to move the call of DumpPreUserCmd before execution of > > > BackupPC_backupDuplicate > > > to allow a users DumpPreUserCmd to disable hibernation on client side. > > > > > > You said it required to use a $Conf{patch-defined-command}. > > > > 'Require' is perhaps a stronger word than I would have used, but OK, > > what I said is effectively the same thing. :) > > > > > I can easily implement it in my config.pl and in the BackupPC_dump patch. > > > Would this be > > > sufficient > > > to apply it in a master branch? > > > > Yes. The idea is that if people want to try it out they can, but if > > they don't then they also don't need to worry about it and IMPORTANTLY > > they also don't need to backport any fixes to existing configurations. > > > > > Or would you expect to put it also in the web UI? > > > > No, I much prefer *not* to change the UI. That's asking for trouble. > > > > > I've done this in 2014 with another patch in BackupPC 3.1. It was a > > > lot of work and testing ?? > > > > I'm sure it was. As far as possible I want to leave the Web UI alone: > > > > 1. There are in any case already things in the configuration that the > > Web UI cannot change. > > > > 2. As it is, the UI code is a nightmare. Adding complexity will give > > more things more opportunities to go wrogn. > > > > 3. To improve security, the lowest hanging fruit by a long way is the > > Web server. BackupPC works just fine without one. (But you may need > > to dust off that text editor manual. Read the bit about old versions > > being saved with an incrementing suffix. If that isn't an option for > > your editor, you can always install Emacs. :) > > _______________________________________________ BackupPC-users mailing list [email protected] List: https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki: https://github.com/backuppc/backuppc/wiki Project: https://backuppc.github.io/backuppc/
