On Sun, Jan 25, 2009 at 06:41:43PM +0200, Pasi Kärkkäinen wrote:
> On Sat, Jan 24, 2009 at 05:03:40PM +0100, Kern Sibbald wrote:
> > On Thursday 22 January 2009 16:11:23 Pasi Kärkkäinen wrote:
> > > Hello!
> > >
> > > When 'copy job' is started, name of the original job to be copied is shown
> > > like this:
> > >
> > > bacula-dir JobId 1234: Copying using JobId=1111
> > > Job=original_job_name.original_job_runtime
> > >
> > > That information would be nice to have also in the job report/summary.
> > > Currently there is:
> > >
> > >   Prev Backup JobId:      1111
> > >   New Backup JobId:       1235
> > >   Current JobId:          1234
> > >   Current Job:            copy_job_name.copy_job_runtime
> > >
> > > Would make it a lot easier to read the logs if you could also see the name
> > > of the original job there..
> > 
> > As far as I am aware, the above is exactly what is printed for a Copy job 
> > -- 
> > it uses the same code base as a Migration job.
> 
> Hmm, I wonder if I explained it clearly enough.. 
> 
> Yes, the abobe is exactly what gets printed for a copy job summary/report.
> 
> But I was suggesting to _add_ a "Prev Backup Job" line (or something
> similar), to make it look like this:
> 
> Prev backup Job:      original_job_name.original_job_runtime
> Prev Backup JobId:      1111
> New Backup JobId:       1235
> Current JobId:          1234
> Current Job:            copy_job_name.copy_job_runtime
> 

How about something like this? 

-- Pasi
--- migrate.c.orig	2009-03-24 09:43:36.000000000 +0200
+++ migrate.c	2009-03-24 09:50:29.000000000 +0200
@@ -1290,6 +1290,7 @@
    Jmsg(jcr, msg_type, 0, _("%s %s %s (%s): %s\n"
 "  Build OS:               %s %s %s\n"
 "  Prev Backup JobId:      %s\n"
+"  Prev Backup Job:	   %s\n"
 "  New Backup JobId:       %s\n"
 "  Current JobId:          %s\n"
 "  Current Job:            %s\n"
@@ -1318,6 +1319,7 @@
         BACULA, my_name, VERSION, LSMDATE, edt,
         HOST_OS, DISTNAME, DISTVER,
         edit_uint64(jcr->previous_jr.JobId, ec6),
+	jcr->previous_jr.Job,
         mig_jcr ? edit_uint64(mig_jcr->jr.JobId, ec7) : "0",
         edit_uint64(jcr->jr.JobId, ec8),
         jcr->jr.Job,
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to