> However, I am not too keen on these kinds of submissions, because it is a > rather significant change with little or no benefit.
Do you agree to any open issues that I mentioned in the bug report? http://bugs.bacula.org/view.php?id=1415 > That is it doesn't correct any real problem, and these kinds of changes bring > a *high* > probability of introducing errors, and most of the changes are not necessary > and reduce readability at least in my opinion. I suggest to adjust macro order and parameter quoting for example. > Proof of the above is that your patch has at least one syntax error that I > spotted that as far as I can tell means it will not "compile". Which syntax error do you mean exactly? > You have hard coded the Bacula version number into that file just at > the place where the code takes a bit of pains to automatically configure > itself. Do you mean the proposed specification "AC_INIT([bacula], [3.0.3], [[email protected]])"? http://www.gnu.org/software/autoconf/manual/html_node/Initializing-configure.html Regards, Markus ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
