On Wed, Mar 31, 2010 at 12:11:51PM +0200, Eric Bollengier wrote: > Le mercredi 31 mars 2010 à 10:56 +0100, Graham Keeling a écrit : > > On Wed, Mar 31, 2010 at 11:29:04AM +0200, Eric Bollengier wrote: > > > Hello, > > > > > > Le mercredi 31 mars 2010 à 10:20 +0100, Graham Keeling a écrit : > > > > Hello, > > > > > > > > I upgraded from bacula-3.0.3 to bacula-5.0.1, and bacula immediately > > > > emailed > > > > me this message: > > > > > > > > Warning: On db_name=bacula, MySQL max_connections=100 is lower than > > > > Director > > > > MaxConcurentJobs=1001 > > > > > > > > However: > > > > I have my Directory MaxConcurrentJobs set to 1000. > > > > The warning spelt MaxConcurrentJobs wrong. > > > > > > Why did you say that it's wrong? > > > > Because MaxConcurrentJobs is spelt wrong and in my bacula-dir.conf, Director > > MaxConcurrentJobs!=1001. > > At this place, we have no real idea on MaxConcurrentJobs value, so I > will just remove this word from the message.
The function is db_check_max_connections() in cats/sql.c, which takes a 'unit32_t max_concurrent_jobs'. The only place that uses this function gives it director->MaxConcurrentJobs+1, so you can subtract 1 in the message. Or (better) pass in the real MaxConcurrentJobs and do all the additions and subtractions entirely inside db_check_max_connections(). Anybody else that wants to use db_check_max_connections() will then not need to know the magic of adding 1. > Something like > > Warning: On db_name=bacula, MySQL max_connections=100 should be greater than > 1001. I think that is even less helpful, as you have now lost the suggestion to reconfigure bacula. > Bye > > > > Bacula needs some extra connections, so > > > the number is accurate. If you have a suggestion for a better message, > > > feel free to propose it. Something like "lower than Director > > > MaxConcurentJobs=1000 + extra internal connection=1" is more accurate, > > > but also useless and complex. > > > > A normal human being should not need to know about bacula's internal > > workings. > > I agree that your suggestion is complex (though not useless). > > > > > This message is quite clear, you need to use at least 1001 in your mysql > > > configuration. > > > > Alternatively, I need less than 100 in my bacula configuration. > > I'm configuring bacula, not mysql. > > > > Here are two suggestions for a better messsage: > > > > Warning: On db_name=bacula, Director MaxConcurrentJobs=1000 should be less > > than MySQL max_connections=100. > > > > Warning: On db_name=bacula, MySQL max_connections=100 should be greater than > > Director MaxConcurrentJobs=1000. > > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
