On Wednesday 28 April 2010 13:28:20 Martin Simmons wrote: > >>>>> On Wed, 28 Apr 2010 11:35:48 +0200, Kern Sibbald said: > > > > On Wednesday 28 April 2010 11:26:30 Martin Simmons wrote: > > > >>>>> On Tue, 27 Apr 2010 10:26:49 -0400, Brian Debelius said: > > > > > > > > Hi, > > > > > > > > I am testing 5.0.1 on a new server with a SAS LTO-3 drive, and Ubuntu > > > > Lucid. Btape says the test succeeded and then says it failed. Did > > > > it fail? > > > > > > > > Wrote block=1640000, file,blk=99,14449 VolBytes=424,668,823,552 > > > > rate=49.10 MB/s > > > > 22-Apr 16:51 btape JobId 0: End of Volume "TestVolume1" at 100:2157 > > > > on device "Tape" (/dev/nst0). Write of 262144 bytes got -1. > > > > 22-Apr 16:51 btape JobId 0: Re-read of last block succeeded. > > > > btape: btape.c:2701 Last block at: 100:2156 this_dev_block_num=2157 > > > > btape: btape.c:2736 End of tape 100:0. Volume Bytes=425,741,254,656. > > > > Write rate = 49.05 MB/s > > > > btape: btape.c:2311 Wrote 1000 blocks on second tape. Done. > > > > Done writing 0 records ... > > > > btape: btape.c:2380 Wrote state file last_block_num1=2156 > > > > last_block_num2=0 btape: btape.c:2395 > > > > > > > > 16:51:11 Done filling tape at 100:0. Now beginning re-read of tape > > > > ... btape: btape.c:2476 Enter do_unfill > > > > 22-Apr 16:51 btape JobId 0: Ready to read from volume "TestVolume1" > > > > on device "Tape" (/dev/nst0). > > > > Rewinding. > > > > Reading the first 10000 records from 0:0. > > > > 10000 records read now at 1:1251 > > > > Reposition from 1:1251 to 100:2156 > > > > Reading block 2156. > > > > > > > > The last block on the tape matches. Test succeeded. > > > > > > > > btape: btape.c:2403 do_unfill failed. > > > > > > It succeeded. > > > > > > The code looks slightly broken because it doesn't set the return value > > > correctly when the simplified test succeeds, which causes this > > > do_unfill failed message to be printed as well. > > > > Martin, could you send us a patch to fix that? > > I've attached the simplest patch (untested). It isn't pretty.
It looks pretty clean to me :-) Thanks, Kern > > __Martin ------------------------------------------------------------------------------ _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
