On Tuesday 15 June 2010 12:43:19 Luca Berra wrote:
> On Tue, Jun 15, 2010 at 10:03:03AM +0200, Kern Sibbald wrote:
> >On Tuesday 15 June 2010 09:01:41 Luca Berra wrote:
> >> --- bacula-5.0.2/src/cats/sqlite.c~ 2010-04-27 15:58:29.000000000
> >> -0400
> >> +++ bacula-5.0.2/src/cats/sqlite.c 2010-06-14 06:15:31.000000000 -0400
> >> @@ -279,7 +279,7 @@
> >>
> >> void db_thread_cleanup()
> >> {
> >> -#ifdef HAVE_SQLITE3
> >> +#ifdef HAVE_SQLITE3_THREADSAFE
> >> sqlite3_thread_cleanup();
> >> #endif
> >> }
> >
> >I am not 100% sure that I would like to include this patch. Bacula will
> > not run correctly if you do not have a thread safe version of sqlite3, so
> > I think it would be better not to build if the sqlite is not correctly
> > built.
>
> i admit i am not 100% fluent with the sqlite code, but reading code
> above those lines:
> 268 void db_check_backend_thread_safe()
> 269 {
> 270 #ifdef HAVE_BATCH_FILE_INSERT
> 271 if (!sqlite3_threadsafe()) {
> 272 Emsg0(M_ABORT, 0, _("SQLite3 client library must be thread-safe
> " 273 "when using BatchMode.\n"));
> 274 }
> 275 #endif
> 276 }
>
> I understood thread safe was required only if using batch inserts.
> In case this is not true it would be better making configure abort if we
> don't have a threadsafe sqlite3.
Technically, possibly Bacula will run without a thread safe SQLite3 if batch
insert is not turned on, but batch insert is the default, and we may even
eliminate non-batch-insert code at some point, so I would prefer to require
thread_safe to be enabled. I will take a look at the code and see what
should be cleaned up.
Thanks for pointing this out.
Kern
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
