Hi,
when using a client side run script, the job codes are evaluated by the
fd. Unfortunately, this results in a broken evaluation of the director
name %d (which is translated to the variable "myname", containing the
_client_ name in the fd rather than the director name).
This has been checked in 5.2.1 and 5.0.3.
I see the following options (and will be happy to implement one of them, if
appropriate):
- Evaluate the runscript commands on the director side (move the
edit_job_codes call from lib/runscript.c to all locations where runscripts
are stored, in this case dird/fd_cmds.c)
- Evaluate run scripts twice, passing sets of appropriate codes (just evaluate
%d on the director, all others on the fd). I'd modify the function's
prototype in that case.
- Don't use "myname" for %d, but something better. I don't see the dir name
stored in the jcr structure, however?
- Create a new appropriate variable in the fd, and modify %d for that variable
prior to executing edit_job_codes
Any thoughts on that topic?
Thx
Bastian
PS: The topic is related to the job code callback stuff which I sent a cleanup
patch for on 2008-07-16 (Subject "Re: [Bacula-devel] Clone jobs and storage").
Feel free to re-consider taking this or a similar patch upstream. I have an
updated patch for 5.2.1, just in case ...
--
Collax GmbH . Basler Str. 115a . 79115 Freiburg . Germany
p: +49 (0) 89-990 157-28 www.collax.com
Geschäftsführer: Bernd Bönte, Boris Nalbach
AG München HRB 173695. Ust.-IdNr: DE270819312
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
