Kern Sibbald wrote (2006/01/18):
> > > I have tested both Bacula-1.38.3 and Bacula-1.38.4 now too: Unfortunately
> > > they are broken as Bacula-1.38.2 too - the first argument is discarded.
> > > As a workaround, you can use
> > > label ANYTHING slots=NNN storage=SSS pool=PPP barcodes
> > > for now - ANYTHING is simply discarded and all other arguments are
> > > taken into an account.
> > One very important question - will you report that at bugs.bacula.org or
> > should I do so?
Let's wait on word from Kern ;o)
> I am unable to reproduce this on version 1.38.4, so if someone submits it to
> the bugs database, be sure to include "proof" that there is a bug. You might
It seems, that you have tried "barcode" instead of our "barcodes".
When "barcode" is used, zeroth "label" is zapped, which seems to be
further ignored. However when "barcodes" is used, first argument is
zapped, because i = find_arg_keywords() returns an index of found
keyword and not an index of found argument as in find_arg(). As
one of possible solutions, here is my version of somewhat defensive
patch (*ua->argk[find_arg(ua, barcode_keyword[i])] = 0; can be safely
used too):
--- src/dird/ua_label.c.orig Thu Jan 19 10:05:21 2006
+++ src/dird/ua_label.c Thu Jan 19 10:07:50 2006
@@ -305,7 +305,9 @@
}
if (!relabel && (i=find_arg_keyword(ua, barcode_keyword)) >= 0) {
- *ua->argk[i] = 0; /* zap barcode keyword */
+ i = find_arg(ua, barcode_keyword[i]);
+ if (i > 0)
+ *ua->argk[i] = 0; /* zap barcode keyword */
label_barcodes = true;
}
Should I fill a bug report, or is this sufficient? ;o)
Regards.
--
Rudolf Cejka <cejkar at fit.vutbr.cz> http://www.fit.vutbr.cz/~cejkar
Brno University of Technology, Faculty of Information Technology
Bozetechova 2, 612 66 Brno, Czech Republic
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users
