Hi Peter: Am 27.07.16 18:33 schrieb(en) Peter Bloomfield:
I noticed that $use_threads is still referenced in a couple of places in configure.ac, although it's never set.
Ouch.
One is in the configuration summary, where it causes no harm and can presumably just be deleted.
Yes, that will be just confusing.
The other is in checking the gpgme config, where it appears that different libs are needed in the pthread and non-pthread cases. As I read it, we're currently using the non-pthread lib--is that correct? I haven't seen any issues with this version, but I may not have exercised gpgme very completely.
I am not sure if we really need the thread-safe version of gpgme, but I guess there /might/ be more than one thread in balsa accessing gpgme simultaneously [1]. So, yes, we /should/ use the thread-safe version. And I noticed that the thread-unsafe function gpgme_strerror() is used in three places (libbalsa/gmime-gpgme-signature.c, libbalsa/libbalsa-gpgme.c, libbalsa/rfc3156.c). The attached revised patch fixes these issues, on top of the first one. Thanks a lot for pointing me to that! Cheers Albrecht. [1] <https://www.gnupg.org/documentation/manuals/gpgme/Multi-Threading.html#index-thread_002dsafeness>
threads_rev2.diff.bz2
Description: application/bzip
pgpGCawLfnmNC.pgp
Description: PGP signature
_______________________________________________ balsa-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/balsa-list
