Hi Peter! First, thanks a lot for testing these (bulky) changes! I'll try to split the next steps into smaller chunks…
Am 23.10.18 01:04 schrieb(en) Peter Bloomfield:
Thanks for the work, and the patch! It applies and builds[0]
[snip]
[0] I had to add an additional FALSE argument to some libbalsa-conf calls in address-book-ldap.
Ouch - yes, I forgot to run a text search for the new api (I do not build with LDAP support). I noticed that the LDAP Bind password is stored in plain text in the private config file. Shouldn't we store it obfuscated? This breaks existent non-anonymous LDAP configs, but the only drawback is that the user has to enter the password again. Or we might want to move the libsecret stuff libbalsa-conf, so the password could be stored in the key ring. What do you think? Best, Albrecht.
pgpYVYR8zQXXs.pgp
Description: PGP signature
_______________________________________________ balsa-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/balsa-list
