Nitpickings
l.30
s/Invalide/invalid/
s/please/Please/
remove extraneous parenthesis around `ftype`
l.40
remove extraneous parenthesis around `col`
l.80,93,113,128
I would recommend the new syntax python3-like for the exceptions as it is more
readable
except Exception as err:
BTW, I don't have the context here, but don't we have a more precise exception
to catch?
l.147
s/convertion/conversion/
l.149
return float(val) if val else 0.0
--
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-improve-import-usability/+merge/148665
Your team Banking Addons Team is requested to review the proposed merge of
lp:~camptocamp/banking-addons/bank-statement-reconcile-70-improve-import-usability
into lp:banking-addons/bank-statement-reconcile-70.
--
Mailing list: https://launchpad.net/~banking-addons-team
Post to : [email protected]
Unsubscribe : https://launchpad.net/~banking-addons-team
More help : https://help.launchpad.net/ListHelp
