Review: Disapprove code review, no tests Hi,
Thanks for the contribs. I'm not convinced by this approach as you may commit some unwanted stuff which is probably worst than having errors and loosing everything. For that reason, I set this MP to disaprove. Can't you import a part of the writing before launching the reconciliation ? In a "normal" context, the cron will never parse at once that much record right ? May be I'm missing something here. A second opinion would be welcome and I may change my review then. Regards, Joël -- https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-account-easy-reconcile-add-commit/+merge/197756 Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
