Review: Needs Fixing code review, no tests

Hi,


Thanks for this contrib ! This is an amazing feature !

Few remarks:

 * 58-72: please adapt the text and tag (*_xml is deprecated, description is 
empty, name is not good, etc..)
 * Lots of line are too long (max 80 char)
 * Line 141: context=None + line below: if context is None: context={}
 * Line 156: context=None

Otherwise good !

Thanks !

++

Joël
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-7.0-one-move/+merge/197769
Your team Banking Addons Core Editors is subscribed to branch 
lp:banking-addons/bank-statement-reconcile-7.0.

-- 
Mailing list: https://launchpad.net/~banking-addons-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~banking-addons-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to