Review: Needs Fixing Awesome, finally a generic MT940 parser!
Just two comments from code review, I'll do some testing later on: - l.122 You might want to add a comment that the exception handling here allows you to execute the file to test the parser outside the context of the OpenERP server (I think). - l.165 Quite a fashion statement ;-) I know this runs, but you might want to either add two single quotes at the start or remove two at the end so that it looks like a regular docstring. -- https://code.launchpad.net/~therp-nl/banking-addons/6.1-account_banking_nl_ing_mt940/+merge/208430 Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/6.1. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
