Review: Needs Information code review Hi,
I would like to propose an alternative based on the principles enunciated by Stéphane. I'm also uneasy with the proposed mechanism that requires to subclass the AccountStatementProfile class and stores the parser state in the context. By looking in more detail in the code, I can not find overrides or other usages of the import_statement method than the one in the CreditPartnerStatementImporter wizard. Therefore, IMO, it's not a problem to change the 'statement_import' function to make the code more natural. You can find a first draft of the proposed alternative at http://bazaar.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-multi-statements/revision/147 Best regards, lmi -- https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-multi-statements/+merge/209863 Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
