On Sun, 2010-12-12 at 10:52 +0200, Vlad Dragu wrote: > I've gone through all the bugs and code review issues, except the ie6 > bug which i'll handle on Monday night from the office.
Hi Vlad, I've had a look at your commit history, and found a few issues that prevented me from merging it to the trunk: http://bazaar.launchpad.net/~vlad-dragu/hackit/alpha2.0/revision/151 : This would remove the "versioning" table, which was apparently missing from your database when you ran the 'make release'. http://bazaar.launchpad.net/~vlad-dragu/hackit/alpha2.0/revision/152 : Why do you remove the "error_reporting(E_ALL & ~E_DEPRECATED);"? I've added it on purpose, to make sure we all run tests with the same error reporting configuration - did it create issues? http://bazaar.launchpad.net/~vlad-dragu/hackit/alpha2.0/revision/153 : This one is probably just me, but I couldn't understand why this would fix the bug https://bugs.launchpad.net/hackit/+bug/676908 . I've updated the bug to keep the discussion in one place - let me know! Xavier. _______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
