Hi, Here is the log of the chatroom at http://farsides.com/chat/ (or irc://irc.freenode.net/#farsides) for the 2011-08-26.
2011-08-26 01:12:57+0000 mtyaka (mtyaka) is now online 2011-08-26 07:17:32+0000 MCMic (MCMic) is now online 2011-08-26 08:33:50+0000 blanchard (blanchard) is now offline 2011-08-26 08:34:03+0000 <mtyaka> hi everybody! 2011-08-26 08:34:48+0000 <mtyaka> antoviaque: i have some questions regarding code reviews, whenever you are ready. 2011-08-26 08:34:57+0000 <antoviaque> hi mtyaka : ) 2011-08-26 08:35:04+0000 <antoviaque> sure, we can discuss this now 2011-08-26 08:35:26+0000 <mtyaka> hi! i wasn't sure you were here already :) 2011-08-26 08:35:54+0000 <mtyaka> i have gone through some of the tasks in arbrandes' queue and reviewed them 2011-08-26 08:35:57+0000 <antoviaque> hehe, I usually am around in the morning : ) 2011-08-26 08:36:12+0000 <antoviaque> cool 2011-08-26 08:36:47+0000 <mtyaka> first question: it is rather time consuming - i spent 4 hours reviewing 11 items 2011-08-26 08:36:59+0000 <mtyaka> is that "normal" or should i try to spend less time on it? 2011-08-26 08:37:38+0000 <mtyaka> and related question, are we going to create separate tasks for reviews to track the time? 2011-08-26 08:37:51+0000 <antoviaque> it depends on the items - how much work from arbrandes does that represent? 2011-08-26 08:38:14+0000 <mtyaka> let me se... 2011-08-26 08:38:53+0000 <antoviaque> I was more thinking of one task per month for this - we estimate the time for the month once this way, and then it gives a budget to spend on reviews 2011-08-26 08:40:49+0000 <mtyaka> the 11 tasks amount to 62 hours of Adolfo's work, if I calculated correctly 2011-08-26 08:41:11+0000 <antoviaque> so 1.5-2 weeks 2011-08-26 08:41:33+0000 <antoviaque> it's not surprising to spend 4 hours on that volume of work - to do it well it does take time 2011-08-26 08:42:11+0000 <mtyaka> ok, next question: how do i mark the tasks as reviewed? 2011-08-26 08:42:21+0000 <antoviaque> on the other side it's the beginning, I expect it to become shorter as you both get used to it 2011-08-26 08:42:40+0000 <antoviaque> can you put them as merged? 2011-08-26 08:43:00+0000 <antoviaque> if all is good => "merged", otherwise => back to "in progress" 2011-08-26 08:43:19+0000 <mtyaka> i think i tried that, i probably don't have the permissions... let me see again. 2011-08-26 08:43:36+0000 * antoviaque having a look at permissions 2011-08-26 08:44:00+0000 <mtyaka> nope, i can only choose between "ready for review" and "in progress" 2011-08-26 08:45:13+0000 <antoviaque> I gave you the "senior" permissions, you should be able to mark as merged I think now 2011-08-26 08:45:51+0000 <mtyaka> yes, i can do that now, thanks! 2011-08-26 08:45:55+0000 <antoviaque> :) 2011-08-26 09:12:51+0000 <mtyaka> antoviaque: in cardstories, we always use classes to name elements, never IDs. What is the rationale behind this? 2011-08-26 09:15:38+0000 <antoviaque> mtyaka: good question - I don't know the reason behind it, as sometimes it's clearly a single element and we could use the id - maybe to be sure there are never two identical ids in unrelated parts of the dom 2011-08-26 09:15:53+0000 <antoviaque> the way we currently do it, it doesn't matter, since we always use a given dom context 2011-08-26 09:16:10+0000 <mtyaka> antoviaque: that's what i thought 2011-08-26 09:16:59+0000 <mtyaka> the reason i am asking is because Adolfo was forced to introduce IDs for some elements, because spritely needs the elements it is animating to have IDs 2011-08-26 09:17:35+0000 <antoviaque> Yes, in those cases I don't think there is a choice yep 2011-08-26 09:17:43+0000 <mtyaka> so now we can either give up on preferring classes as IDs will generally be more efficient... 2011-08-26 09:18:09+0000 <mtyaka> ... or we could try to work around the problem by generating random IDs for spritely dynamically 2011-08-26 09:19:06+0000 <mtyaka> as you say, the way it currently works, it probably doesn't make sense to go through such trouble to make spritely happy 2011-08-26 09:19:17+0000 <antoviaque> Would be worth discussing with arbrandes, but I don't think it's worth the trouble - I generally have a much more "hackish" style than dachary however, so I may not be the right reference on this :p 2011-08-26 09:19:43+0000 <mtyaka> hehe, ok 2011-08-26 09:20:27+0000 <mtyaka> i think if we agree that it is ok to use IDs, then everything is ok, we can use IDs in other places as well 2011-08-26 09:21:10+0000 <mtyaka> but if this was just an exception and in other places we would still stick with classes, then it doesn't feel quite right to me 2011-08-26 09:21:18+0000 <antoviaque> I would probably try to keep the convention where it's easy to do so, for consistency 2011-08-26 09:21:49+0000 <antoviaque> yes, that's where my hackish style isn't too bothered :) 2011-08-26 09:22:46+0000 <mtyaka> ok :) i will mark as merged and post my thoughts as a comment on the ticket 2011-08-26 09:23:24+0000 <mtyaka> antoviaque: for some reason, i can't seem to be able to mark #303 as merged 2011-08-26 09:23:27+0000 <antoviaque> yup - could be worth putting a link to it on the buddypress, as once a task is closed it's easy to miss 2011-08-26 09:23:37+0000 <antoviaque> let me see 2011-08-26 09:24:31+0000 <antoviaque> yup, me neither - I think it's because it's blocked by #325, which has to be closed first 2011-08-26 09:25:29+0000 <mtyaka> oh, i see. i reviewed #325 too, so i'll close that first 2011-08-26 11:47:07+0000 arbrandes (arbrandes) is now online 2011-08-26 11:49:12+0000 tartarugafeliz (tartarugafeliz) is now online 2011-08-26 12:02:50+0000 <antoviaque> eve: start dailymeeting 2011-08-26 12:02:50+0000 * eve antoviaque arbrandes blanchard blanchard1 dachary mtyaka tartarugafeliz and al: daily meeting starts! Please say "eve_: yesterday|today|blockers <your report>" 2011-08-26 12:02:52+0000 <arbrandes> eve_, yesterday : Finished new board on player view (#399). 2011-08-26 12:02:52+0000 <eve> Done: : Finished new board on player view (#399) 2011-08-26 12:02:52+0000 <arbrandes> eve_, today : Create more tasks and get started on story #345 (play back author picking a card). 2011-08-26 12:02:52+0000 <eve> Next: : Create more tasks and get started on story #345 (play back author picking a card) 2011-08-26 12:02:52+0000 <arbrandes> eve_, blockers : None! 2011-08-26 12:02:52+0000 <eve> Blockers: : None 2011-08-26 12:02:54+0000 <antoviaque> hi everyone : ) 2011-08-26 12:02:55+0000 <antoviaque> ahahaha 2011-08-26 12:03:03+0000 <arbrandes> Back to my old form ;) 2011-08-26 12:03:07+0000 <arbrandes> morning! :) 2011-08-26 12:03:09+0000 <antoviaque> my god, do you really stay ready to hit enter? :p 2011-08-26 12:03:16+0000 <antoviaque> good morning :D 2011-08-26 12:03:19+0000 <arbrandes> antoviaque, yes. Yes I do. 2011-08-26 12:03:20+0000 <arbrandes> hahahahha 2011-08-26 12:03:32+0000 <antoviaque> ahahaha - you're crazier than I thought :p 2011-08-26 12:03:51+0000 <antoviaque> all going fine with the player views btw? 2011-08-26 12:03:55+0000 <arbrandes> I'll guarantee that I'm *much* crazier than you think, heheheh 2011-08-26 12:03:56+0000 <antoviaque> eve_: yesterday Work on Plebia - modifying the way episodes are handled (exploring kat.ph & thetvdb.com for episodes listings) 2011-08-26 12:03:56+0000 <eve> Done: Work on Plebia - modifying the way episodes are handled (exploring kat.ph & thetvdb.com for episodes listings) 2011-08-26 12:03:56+0000 <antoviaque> eve_: today Work on Plebia - modifying the way episodes are handled 2011-08-26 12:03:56+0000 <eve> Next: Work on Plebia - modifying the way episodes are handled 2011-08-26 12:03:56+0000 <antoviaque> eve_: blockers none 2011-08-26 12:03:56+0000 <eve> Blockers: none 2011-08-26 12:03:59+0000 <arbrandes> antoviaque, so far so good 2011-08-26 12:04:07+0000 <antoviaque> arbrandes: ahaha, you get me curious ;p 2011-08-26 12:04:09+0000 <antoviaque> good! 2011-08-26 12:04:13+0000 <antoviaque> mtyaka: ? 2011-08-26 12:04:22+0000 <mtyaka> eve_: yesterday I reviewed 11 tasks out of Adolfo's ready for review queue. 2011-08-26 12:04:22+0000 <eve> Done: I reviewed 11 tasks out of Adolfo's ready for review queue 2011-08-26 12:04:24+0000 <mtyaka> eve_: today I will review the next batch from the queue 2011-08-26 12:04:24+0000 <eve> Next: I will review the next batch from the queue 2011-08-26 12:04:25+0000 <mtyaka> eve_: blockers none! 2011-08-26 12:04:25+0000 <eve> Blockers: none 2011-08-26 12:05:23+0000 <arbrandes> thanks mtyaka, I'll do the same for you today 2011-08-26 12:05:45+0000 <mtyaka> arbrandes: thanks :) 2011-08-26 12:05:55+0000 <antoviaque> mtyaka: thanks yep : ) 2011-08-26 12:06:23+0000 <antoviaque> and following this morning's conversation, if you want to create a task for it, we can do one task per month 2011-08-26 12:06:57+0000 <antoviaque> same principle - an estimate for the month (will probably need to be reestimated the first times) 2011-08-26 12:07:02+0000 <antoviaque> sounds good? 2011-08-26 12:07:22+0000 <mtyaka> antoviaque: sounds good to me 2011-08-26 12:08:07+0000 <antoviaque> arbrandes: good for you too? I'll leave it up to you to create a task or not for this, but know that you can : ) 2011-08-26 12:09:21+0000 <arbrandes> thanks, antoviaque, if I end up spending a lot of time on it, I'll think about it. Don't think it will be necessary this month, though. 2011-08-26 12:09:31+0000 <antoviaque> okidok - and thanks! 2011-08-26 12:09:47+0000 <antoviaque> ok, blanchard is on his way to canada, so not here : ) 2011-08-26 12:09:53+0000 <antoviaque> tartarugafeliz: ? 2011-08-26 12:10:35+0000 <tartarugafeliz> eve_: yesterday I worked on #380 (Design CNC document) 2011-08-26 12:10:35+0000 <eve> Done: I worked on #380 (Design CNC document) 2011-08-26 12:10:36+0000 <tartarugafeliz> eve_: today and the rest of the week I'll work on #380 (Design CNC document) 2011-08-26 12:10:36+0000 <eve> Next: and the rest of the week I'll work on #380 (Design CNC document) 2011-08-26 12:10:36+0000 <tartarugafeliz> eve_: blockers none 2011-08-26 12:10:36+0000 <eve> Blockers: none 2011-08-26 12:10:57+0000 <antoviaque> hehe, I guess it will be that CNC documents for a few days now : ) 2011-08-26 12:11:11+0000 <tartarugafeliz> yeap 2011-08-26 12:11:12+0000 <tartarugafeliz> hahaha 2011-08-26 12:11:14+0000 <antoviaque> ok, all good? anything else to discuss? 2011-08-26 12:11:23+0000 <arbrandes> hehehe, tartarugafeliz, poor you 2011-08-26 12:11:27+0000 <arbrandes> nope 2011-08-26 12:11:33+0000 <tartarugafeliz> its ok I'm very strong! :D 2011-08-26 12:11:39+0000 <antoviaque> :p 2011-08-26 12:11:42+0000 <arbrandes> :) 2011-08-26 12:11:48+0000 <antoviaque> SCHTROOOONG turtle 2011-08-26 12:11:52+0000 <tartarugafeliz> haahahahaha 2011-08-26 12:12:03+0000 <antoviaque> eve: end dailymeeting 2011-08-26 12:12:04+0000 <eve> Meeting Ended 2011-08-26 12:12:04+0000 <eve> Minutes available at http://paste.pocoo.org/show/464792 2011-08-26 12:12:09+0000 <arbrandes> lol 2011-08-26 12:12:15+0000 <antoviaque> thx :) 2011-08-26 12:12:33+0000 <arbrandes> np 2011-08-26 12:52:26+0000 <mtyaka> antoviaque: I'm about to create the task for code reviews. What title should I give it? "Code reviews - August 2011"? 2011-08-26 12:53:01+0000 <antoviaque> yep - you can also put your name in it, since there will be one task per reviewer 2011-08-26 12:53:16+0000 <mtyaka> ah, right 2011-08-26 12:53:26+0000 <mtyaka> Code Reviews - Matjaz, August 2011 2011-08-26 12:53:31+0000 <antoviaque> perfect : ) 2011-08-26 12:53:34+0000 <antoviaque> thx! 2011-08-26 12:53:46+0000 <mtyaka> and it seems i have the power to create a new category... 2011-08-26 12:53:54+0000 <mtyaka> should i create a new category "Code Review" ? 2011-08-26 12:54:10+0000 <antoviaque> Yup, sounds good 2011-08-26 12:59:13+0000 <mtyaka> antoviaque: as for the estimate, does 9 hours seem reasonable? I spent 4, I have 13 tasks in the review queue, together worth 48 hours of coding time, and I am expecting arbrandes will have some more tasks ready for review until the end of the month 2011-08-26 12:59:57+0000 <antoviaque> yep, sounds good for a first guess 2011-08-26 13:00:59+0000 <mtyaka> thanks! 2011-08-26 13:01:14+0000 <mtyaka> Task created as #401 2011-08-26 13:18:54+0000 tartarugafeliz (tartarugafeliz) is now online 2011-08-26 13:19:39+0000 antoviaque (antoviaque) is now online 2011-08-26 13:26:39+0000 dachary (dachary) is now online 2011-08-26 13:40:30+0000 dachary (dachary) is now online 2011-08-26 14:14:16+0000 dachary1 (dachary1) is now online 2011-08-26 14:21:47+0000 <arbrandes> antoviaque, are redmine notification emails going out normally? I don't seem to be getting any. 2011-08-26 14:21:55+0000 <antoviaque> let me see 2011-08-26 14:22:56+0000 <antoviaque> I see some email going through yep 2011-08-26 14:23:06+0000 <antoviaque> Aug 26 14:20:23 redmine postfix/smtp[4779]: 0F80B25A04: to=<[email protected]>, relay=mail.plebia.org[91.121.41.27]:25, delay=0.2, delays=0.04/0.01/0.05/0.09, dsn=2.0.0, status=sent (250 2.0.0 Ok: queued as EF6BB32D822C) 2011-08-26 14:23:07+0000 <antoviaque> Aug 26 14:20:25 redmine postfix/smtp[4780]: 0F80B25A04: to=<[email protected]>, relay=gmail-smtp-in.l.google.com[209.85.229.27]:25, delay=2.1, delays=0.04/0.01/0.52/1.6, dsn=2.0.0, status=sent (250 2.0.0 OK 1314368425 el6si4409044wbb.23) 2011-08-26 14:23:18+0000 <arbrandes> weird, I didn't get any notifications for mtyaka's reviews 2011-08-26 14:23:48+0000 <arbrandes> As a matter of fact, I never get *any* redmine notifications, hehehe 2011-08-26 14:24:00+0000 <antoviaque> Aug 26 09:29:55 redmine postfix/smtp[1829]: 5BF6625A04: to=<[email protected]>, relay=gmail-smtp-in.l.google.com[209.85.229.27]:25, delay=1.6, delays=0.04/0/0.16/1.4, dsn=2.0.0, status=sent (250 2.0.0 OK 1314350995 fw18si3794973wbb.68) 2011-08-26 14:24:04+0000 <antoviaque> even that one? 2011-08-26 14:24:32+0000 <arbrandes> nope... really weird, let me see if it's in my spam box 2011-08-26 14:25:10+0000 <arbrandes> ahah, yup, gmail thinks it's spam 2011-08-26 14:25:13+0000 <antoviaque> :) 2011-08-26 14:25:14+0000 <arbrandes> sorry for the trouble 2011-08-26 14:25:33+0000 <antoviaque> np - welcome to the world of spam from redime :p 2011-08-26 14:25:36+0000 <antoviaque> redmine 2011-08-26 14:25:55+0000 <arbrandes> hehehehe :) 2011-08-26 14:26:06+0000 <antoviaque> you'll regret hehehe ;p 2011-08-26 14:26:15+0000 <arbrandes> I'm already starting to think so, hahahahah 2011-08-26 14:36:53+0000 xrogaan (xrogaan) is now online 2011-08-26 14:36:53+0000 xrogaan (xrogaan) is now online 2011-08-26 14:39:25+0000 dachary (dachary) is now online 2011-08-26 14:53:29+0000 dachary (dachary) is now online 2011-08-26 14:56:39+0000 dachary (dachary) is now online 2011-08-26 15:27:39+0000 MCMic (MCMic) is now online 2011-08-26 16:50:55+0000 dachary (dachary) is now online 2011-08-26 18:09:24+0000 dachary (dachary) is now online 2011-08-26 18:48:02+0000 dachary (dachary) is now online 2011-08-26 21:35:21+0000 dachary (dachary) is now online 2011-08-26 23:00:21+0000 dachary (dachary) is now online _______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
