On Tue, 2012-09-04 at 10:48 +0200, Sascha Hauer wrote: > On Mon, Sep 03, 2012 at 01:46:04PM +0200, Jan Luebbe wrote: > > Signed-off-by: Jan Luebbe <j...@pengutronix.de> > > --- > > arch/arm/mach-omap/Kconfig | 4 ++++ > > arch/arm/mach-omap/omap3_clock.c | 35 +++++++++++++++++++++++++---------- > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig > > index a781287..82fa46b 100644 > > --- a/arch/arm/mach-omap/Kconfig > > +++ b/arch/arm/mach-omap/Kconfig > > @@ -61,6 +61,10 @@ config OMAP_CLOCK_UART3 > > bool > > config OMAP_CLOCK_I2C > > bool > > +config OMAP_CLOCK_MMC1 > > + bool > > +config OMAP_CLOCK_SPI > > + bool > > A Kconfig entry for enabling a clock is overkill. Please do not continue > this. > > Right now we have: > > config OMAP_CLOCK_UART > bool > config OMAP_CLOCK_UART2 > bool > config OMAP_CLOCK_UART3 > bool > config OMAP_CLOCK_I2C > bool > > And it's completely unused, so can be simply removed.
What should I do instead? Enable all clocks? Or enable just the clocks for which drivers have been enabled in Kconfig? Thanks, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
