> Hi Alexander, > > On Fri, Mar 08, 2013 at 01:05:14PM +0400, Alexander Shiyan wrote: > > This patch extends device_platform_driver macro, so now we allow > > use it with various init levels and subsystems. > > > > Signed-off-by: Alexander Shiyan <[email protected]> > > --- > > include/driver.h | 17 ++++++++++------- > > 1 file changed, 10 insertions(+), 7 deletions(-) > > > > diff --git a/include/driver.h b/include/driver.h > > index 46c56c0..b891f80 100644 > > --- a/include/driver.h > > +++ b/include/driver.h > > @@ -395,16 +395,19 @@ extern struct bus_type platform_bus; > > > > int platform_driver_register(struct driver_d *drv); > > > > -/* device_platform_driver() - Helper macro for drivers that don't do > > +/* register_driver_macro() - Helper macro for drivers that don't do > > * anything special in module registration. This eliminates a lot of > > * boilerplate. Each module may only use this macro once. > > */ > > -#define device_platform_driver(drv) \ > > - static int __init drv ## _register(void) \ > > - { \ > > - return platform_driver_register(&drv); \ > > - } \ > > - device_initcall(drv ## _register) > > +#define register_driver_macro(level,subsystem,drv) \ > > + static int __init drv##_register(void) \ > > + { \ > > + return subsystem##_driver_register(&drv); \ > > + } \ > > + level##_initcall(drv##_register) > > So the usage would look like: > > register_driver_macro(device, i2c, &mc_driver) > > ? > > I'm not sure if I like this. I'm a bit concerned about being able > to grep for for example i2c_register_driver. This would become > > wcgrep register_driver_macro | grep i2c > > or similar.
You are skip 2 important lines: #define device_platform_driver(drv) \ register_driver_macro(device,platform,drv) For i2c we can define new macro like this: #define device_i2c_driver(drv) \ register_driver_macro(device,i2c,drv) then use device_i2c_driver(&foo) in the driver. --- _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
