On Fri, Apr 26, 2013 at 09:09:16PM +0400, Alexander Shiyan wrote: > ... > > > arch/arm/mach-at91/sam9_smc.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm/mach-at91/sam9_smc.c b/arch/arm/mach-at91/sam9_smc.c > > > index b48275e..a137da4 100644 > > > --- a/arch/arm/mach-at91/sam9_smc.c > > > +++ b/arch/arm/mach-at91/sam9_smc.c > > > @@ -120,12 +120,12 @@ void sam9_smc_read(int id, int cs, struct > > > sam9_smc_config *config) > > > > > > static int at91sam9_smc_probe(struct device_d *dev) > > > { > > you fix nothing here > > As far I understand, id can be 0 and 1. In case of dev->id=1, id is not set. > > > > - int id; > > > + int id = dev->id; > > > > > > - if (dev->id < 0) { > > > + if (id < 0) { > > > id = 0; > > > - } else if (dev->id > 1) { > > > - dev_warn(dev, ": id > 2\n"); > > > + } else if (id > 1) { > > > + dev_warn(dev, "id > 1\n");
Also it fixes the error message. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox