On 15:42 Tue 05 Nov , Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy <lis...@gmail.com>
>
> diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
> index 2f31352..6f883bf 100644
> --- a/drivers/net/fec_imx.c
> +++ b/drivers/net/fec_imx.c
> @@ -27,6 +27,8 @@
> #include <linux/clk.h>
> #include <linux/err.h>
> #include <of_net.h>
> +#include <of_gpio.h>
> +#include <gpio.h>
>
> #include <asm/mmu.h>
>
> @@ -643,6 +645,9 @@ static int fec_probe(struct device_d *dev)
> void *base;
> int ret;
> enum fec_type type;
> +#ifdef CONFIG_OFDEVICE
> + int phy_reset;
> +#endif
>
> ret = dev_get_drvdata(dev, (unsigned long *)&type);
> if (ret)
> @@ -671,6 +676,22 @@ static int fec_probe(struct device_d *dev)
>
> fec->regs = dev_request_mem_region(dev, 0);
>
> +#ifdef CONFIG_OFDEVICE
use if (IS_ENABLED(CONFIG_OFDEVICE))
so we can improve the code coverage
> + phy_reset = of_get_named_gpio(dev->device_node, "phy-reset-gpios", 0);
> + if (!gpio_is_valid(phy_reset))
> + goto err_free;
> +
> + ret = gpio_request(phy_reset, "phy-reset");
> + if (ret) {
> + pr_err("Can not request gpio %d (phy-reset): %d\n", phy_reset,
> ret);
> + goto err_free;
> + }
> +
> + gpio_direction_output(phy_reset, 0);
you need to check the return too
> + udelay(10);
> + gpio_set_value(phy_reset, 1);
> +#endif
> +
> /* Reset chip. */
> writel(FEC_ECNTRL_RESET, fec->regs + FEC_ECNTRL);
> while(readl(fec->regs + FEC_ECNTRL) & 1) {
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
