On Mon, Apr 28, 2014 at 10:00:30PM +0200, Sascha Hauer wrote: > On Mon, Apr 28, 2014 at 08:51:21PM +0200, Alexander Aring wrote: > > Hi, > > > > On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote: > > > > > > I think both functions should return 0 without a valid gpio instead. > > > Anyway, there's something wrong here. > > > > > > > maybe checking on this at probe time, at the beginning or can this gpio > > changed at runtime? > > > > Maybe you don't need this here because probe will already failed with a > > invalid gpio. > > No, the gpio is optional. Getting a fixed regulator without software > control is one usecase of the driver, just like in the kernel. >
I understand now. That's why we should return 0, because it's optional. Thanks. - Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
