On Sat, Sep 06, 2014 at 01:21:03PM +0200, Sebastian Block wrote: > Change since v1 (Sascha, thanks for review): > * use xzalloc instead of kzalloc and control check > * correct help and names > * fix coding style issue > * remove verbose and unneeded messages > > This adds support for MTD in RAM devices (like FRAM or MRAM). > > Signed-off-by: Sebastian Block <ba...@linux-source.de>
Your patch has several trailing whitespaces. Please remove them next time. > diff --git a/drivers/mtd/devices/mtdram.c b/drivers/mtd/devices/mtdram.c > new file mode 100644 > index 0000000..47c5ad7 > --- /dev/null > +++ b/drivers/mtd/devices/mtdram.c > + * Strange. the initial '/' introducing the comment is missing here. Also git-am ended up creating an empty file. How did you generate/send this patch? > +static int mtdram_probe(struct device_d *dev) > +{ > + void __iomem *base; > + int device_id; > + struct mtd_info *mtd; > + struct resource *res; > + loff_t size; > + int ret = 0; > + > + mtd = xzalloc(sizeof(struct mtd_info), GFP_KERNEL); xzalloc takes only one argument. Please compile test your patches before sending them. Anyway, fixed this up this time and applied. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox