On Thu, Oct 10, 2019 at 10:15:01AM +0200, Jules Maselbas wrote: > This might fix an endianness bug when the cpu is big-endian > as the string_langid will be converted with `cpu_to_le16` when > sending a control message to get a string descriptor. > > Signed-off-by: Jules Maselbas <jmasel...@kalray.eu> > --- > drivers/usb/core/usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > index e14b89b5e..5dc7993ac 100644 > --- a/drivers/usb/core/usb.c > +++ b/drivers/usb/core/usb.c > @@ -925,7 +925,7 @@ int usb_string(struct usb_device *dev, int index, char > *buf, size_t size) > goto error; > } else { > dev->have_langid = -1; > - dev->string_langid = tbuf[2] | (tbuf[3] << 8); > + dev->string_langid = le16_to_cpu(*((__le16 *)&buf[2]));
You also changed from tbuf to buf. Is this intentional? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox