On Fri, Feb 17, 2023 at 06:30:42PM +0100, Ahmad Fatoum wrote: > LED heartbeat already broke, because upstream renamed the node name. > Fix that and let's use references, so we get errors if an upstream DT > update breaks our usage. > > Signed-off-by: Ahmad Fatoum <[email protected]> > --- > arch/mips/dts/ar9331-dptechnics-dpt-module.dts | 16 ++++++---------- > arch/mips/dts/ar9331.dtsi | 12 +++++------- > 2 files changed, 11 insertions(+), 17 deletions(-) > > diff --git a/arch/mips/dts/ar9331-dptechnics-dpt-module.dts > b/arch/mips/dts/ar9331-dptechnics-dpt-module.dts > index 8a0ae9caf791..da19d7b88ee1 100644 > --- a/arch/mips/dts/ar9331-dptechnics-dpt-module.dts > +++ b/arch/mips/dts/ar9331-dptechnics-dpt-module.dts > @@ -20,18 +20,14 @@ > barebox,provide-mac-address = <ð0>; > }; > }; > +}; > > - leds { > - system { > - barebox,default-trigger = "heartbeat"; > - }; > - }; > +&{/leds/led-0} { > + barebox,default-trigger = "heartbeat"; > +}; > > - gpio-keys { > - button@0 { > - gpios = <&gpio 11 GPIO_ACTIVE_HIGH>; > - }; > - }; > +&{/gpio-keys/button@0} { > + gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
So here is another bug you catched with this series. The upstream device node was renamed to /gpio-keys/button-0. I fixed this up locally here. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
