[PATCH 4/4] bfetch: fix memory leak

[Sascha Hauer]

string_list_join() returns an allocated string. Free it after usage.

Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de>
---
 commands/bfetch.c | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/commands/bfetch.c b/commands/bfetch.c
index 
a44d5a000667c0802a3795bbb64ead9362ebb944..19647deecf0a94e6175fc4e1fad8a4a512c4c3df
 100644
--- a/commands/bfetch.c
+++ b/commands/bfetch.c
@@ -171,9 +171,17 @@ static inline bool __print_string_list(unsigned *line, 
const char *key,
                                       struct string_list *sl,
                                       const char *joinstr)
 {
+       char *str;
+
        if (string_list_empty(sl))
                return false;
-       print_line(key, "%s", string_list_join(sl, joinstr));
+
+       str = string_list_join(sl, joinstr);
+
+       print_line(key, "%s", str);
+
+       free(str);
+
        return true;
 }
 #define print_string_list(k, sl, js) __print_string_list(line, k, sl, js)
@@ -309,8 +317,13 @@ static void print_shell_console(unsigned *line)
 
        for_each_console(console)
                string_list_add(&sl, console->devfs.name);
-       if (!string_list_empty(&sl))
-               print_line("Consoles", "%s", string_list_join(&sl, " "));
+       if (!string_list_empty(&sl)) {
+               char *str = string_list_join(&sl, " ");
+       
+               print_line("Consoles", "%s", str);
+
+               free(str);
+       }
 
        string_list_free(&sl);
 }
@@ -332,8 +345,13 @@ static void print_framebuffers(unsigned *line)
                                         info->bits_per_pixel);
        }
 
-       if (!string_list_empty(&sl))
-               print_line("Framebuffers", "%s", string_list_join(&sl, ", "));
+       if (!string_list_empty(&sl)) {
+               char *str = string_list_join(&sl, ", ");
+
+               print_line("Framebuffers", "%s", str);
+
+               free(str);
+       }
 
        string_list_free(&sl);
 }

-- 
2.47.3