In stat_print() we have to take the filename component of the input path
and retrieve the cdev from that name. Now that we have the cdevname in
struct stat we can simplify this.

Signed-off-by: Sascha Hauer <[email protected]>
---
 fs/fs.c | 25 ++++---------------------
 1 file changed, 4 insertions(+), 21 deletions(-)

diff --git a/fs/fs.c b/fs/fs.c
index 
41cdaf5070798388aa989d16e7bf2ace081b4a2b..4146ecbf3c01229cac89e5acdbc42d66ffc97dfc
 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -137,7 +137,6 @@ void stat_print(int dirfd, const char *filename, const 
struct stat *st)
        struct fs_device *fdev;
        struct cdev *cdev = NULL;
        const char *type = NULL, *typeprefix = "";
-       bool is_cdev_link = false;
        char modestr[11];
 
        mkmodestr(st->st_mode, modestr);
@@ -152,23 +151,10 @@ void stat_print(int dirfd, const char *filename, const 
struct stat *st)
                case S_IFREG:    type = "regular file"; break;
        }
 
-       if (st->st_mode & S_IFCHR) {
-               char *path;
-
-               path = canonicalize_path(dirfd, filename);
-               if (path) {
-                       const char *devicefile = devpath_to_name(path);
-                       struct cdev *lcdev;
-
-                       lcdev = lcdev_by_name(devicefile);
-                       cdev = cdev_readlink(lcdev);
-                       if (cdev != lcdev)
-                               is_cdev_link = true;
-                       if (cdev)
-                               bdev = cdev_get_block_device(cdev);
-
-                       free(path);
-               }
+       if ((st->st_mode & S_IFCHR) && st->st_cdevname) {
+               cdev = cdev_by_name(st->st_cdevname);
+               if (cdev)
+                       bdev = cdev_get_block_device(cdev);
        }
 
        printf("  File: %s", filename);
@@ -182,9 +168,6 @@ void stat_print(int dirfd, const char *filename, const 
struct stat *st)
                        printf(" -> <readlink error %pe>", ERR_PTR(ret));
                else
                        printf(" -> %s", realname);
-       } else if (is_cdev_link) {
-               printf(" ~> %s", cdev->name);
-               typeprefix = "cdev link to ";
        }
 
        printf("\nSize: ");

-- 
2.47.3


Reply via email to