On Thu, Nov 27, 2025 at 10:19:34AM +0100, Lucas Stach wrote: > Hi, > > Am Mittwoch, dem 26.11.2025 um 22:40 -0500 schrieb > [email protected]: > > From: Chali Anis <[email protected]> > > > > the dev might be null, to be sure we move the dev assignation before > > the pci parent assignation. > > This isn't worded strongly enough. pcie->dev will absolutely be NULL at > the point where it is assigned to pci.parent, which seem like a blatant > bug and I don't know how this did ever work or if we just ignored the > broken parent device connection.
This was broken by: commit fd3be9d95f342a3d056a08a8e69fe81fd2a35948 Author: Sascha Hauer <[email protected]> Date: Tue Mar 26 11:07:37 2024 +0100 pci: add pci_controller_init() Upcoming patches will add a list to struct pci_controller. To make sure we have a single point to initialize the list introduce a pci_controller_init() and call it from all drivers which use register_pci_controller(). Make sure host->parent is set correctly before calling register_pci_controller() as that will be needed for device tree parsing later. Link: https://lore.barebox.org/[email protected] Signed-off-by: Sascha Hauer <[email protected]> Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
