On Fri, Jun 01, 2007 at 05:10:27AM -0600, Brian Edginton wrote:
> Here is a patch to add PIN Message and add some additional fields to Message.

Thanks!  I've applied it, as the bulk of it is just fine.  I'm going
through it more closely fixing small things.


> Note that I had to make a change to FieldLinks<T>. It had originally included 
> a direct reference to a Message::Address which wouldn't allow a 
> PINMessage::Address (or others for future adds). I created an Address object 
> in record.h and made the necessary changes in r_message and r_pin_message and 
> record-internal.h.

This is a good idea.  I also added a clear() to Address, to clean up
some of that code and localize it.


> Saved Email Messages is coming next, along with a rough cut at the Message 
> header itself, which will provide the recieved and sent dates, the flags 
> having to do with opened, not read, truncated, saved, etc.

Fantastic.  Thanks very much!


> Chris: I made a quick hack to src/Makefile.am to get these in but you might 
> want to add them differently.

It was missing a backslash, which I've added.


In the PINMessage class, you have a MessageRecordId.  What does this number
represent?  Is it the same as the value passed in to the SetIds() call?

I should do some more experiments here, but thought I'd ask in case
you have some insight.

Thanks,
- Chris


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Barry-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/barry-devel

Reply via email to