On Wed, Jan 07, 2009 at 08:17:47PM +0100, Nicolas wrote:
> Hi,
>
> Before a clean patch with GIT and good integrated in barry project,
> you can try this :
>
> With this patch, I can load a Java application on my BlackBerry Storm.
>
> Test with severals applications (format COD files).
Hi Nicolas!
Well, I'm back from the holidays, and boy have you guys been busy! :-)
Thank you *very* much Nicolas for this patch. It is greatly appreciated
and adds some functionality that people have wanted for a while.
I have some comments on your code before I commit:
- In the files src/m_javaloader.cc and .h, you should add your
name to the top as one of the copyright holders.
I see you copied one of the other modules, so it's fine
to list both NetDirect and you.
- How big can java modules be? I suspect they can be quite large,
maybe even a few megabytes. Does it make sense to force
the library user to always load modules via the filesystem?
It probably makes sense for the majority of the time,
but so far, fopen() calls have been left to the non-library
code.
- In JavaLoader::StartStream(), you seem to do an endian byte swap
for the filesize twice. Is this required?
- Don't hesitate to add named constants for the commands in
protocol.h or protostructs.h.
- MIN_PACKET_SIZE should probably be 5 anyway... I think the correct
fix would be to remove it entirely and just check for
the required size, which in most cases where MIN is used,
is the Packet header size (which is 5).
The idea is that library code should always check that
the data exists before accessing it. It makes more sense
to check for a specific header size than some constant minimum.
- MAX_PACKET_SIZE needs testing... the device will fragment as it
needs, but when uploading, we can't blow the device's limit.
It might make sense to put the fragentation limit in the
Socket class constructor, so that each mode class could
maybe set it as needed. I'll have to look into this more
closely. Comments welcome.
- I'd like to understand the sequence packet stuff better, rather
than turn it off and on like that.
Again, a huge thanks for the patch!
> Idea to improve the patch :
> - parse an ".alx" file to load an application
Depending on the code, this would be a nice item to add to the library.
> - give an URL http://xxxx/app.alx to download application
This would be good to add to the bjavaloader app, not the library.
> - get the list applications installed on the device
> - remove application
Both great to add to the library.
> - your suggestions ? (about patch or improvement)
It looks like you are very familiar with the Java programming steps on Linux,
from installing the JDE to loading into the device. This is important
tutorial information, and any documentation you can write would be
greatly appreciated. Ideally, I'd like to add more pages to the Barry
website that document everything, from the very first steps, right through
to building and installing a Hello World Java app on the Blackberry.
I see on your website that you have some notes there, but more is better.
I'm assuming from some of the comments that English is not your first
language, so I can help with editing if you want. But as for the content,
I'd be learning from your documents just like the rest of the world. :-)
Any help you can provide me with documenting this, even if it is just an
email explaining the steps, would be great.
Thanks,
- Chris
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Barry-devel mailing list
Barry-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/barry-devel
