On Sat, Jan 10, 2009 at 09:40:43AM +0100, Nicolas wrote:
> > - Don't hesitate to add named constants for the commands in
> > protocol.h or protostructs.h.
>
> I don't know always the command mean :(
That's true. I think it is better to add a constant named "UNKNOWN" or
something similar, with a comment as a guess, than to have hard coded
numbers throughout the code. There are still a few hard coded numbers
in even the applied patch, which would be better to have in a header,
and given a name. Even if all we know is that it is part of a response,
that's better than nothing. :-)
#define SB_JL_RESPONSE_UNKNOWN1 0x01
... for example.
> I post the patch on my website to avoid the approuvement and issues :)
>
> http://www.progweb.com/modules/blackberry/
Thanks for this. Your latest patch (which was one diff that had everything
you intended to include) was the easiest to work with.
- Chris
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Barry-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/barry-devel
