On Sun, Feb 15, 2009 at 01:27:46PM -0500, Josh Kropf wrote:
> Attached is a patch that implements the device reset.

Thanks for the patch!  Patch applied and tested on an 8120.


> It seemed most appropriate to put the reset into SocketZero::Close
> since Windows javaloader doesn't start the reset sequence until the
> close command is sent.
> 
> While sending the reset command conditionally from
> JavaLoader::StopStream does work, it causes the close command to fail
> since the device is already resetting.

I can see your reasoning.  I was a little concerned about the proliferation
of flags, but your code seems to handle all cases cleanly, and I couldn't
think of anything better. :-)

Thanks,
- Chris


------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Barry-devel mailing list
Barry-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/barry-devel

Reply via email to